Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ID to nothing if the policy is gone on the API #167

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Set ID to nothing if the policy is gone on the API #167

merged 1 commit into from
Oct 24, 2024

Conversation

bobbytables
Copy link
Contributor

Description

Addresses a bug for when an escalation policy has been deleted in FireHydrant outside of Terraform, an error will occur on re-apply for the plan.

PR readiness

  • Relevant documentation has been updated if this PR adds or updates attributes, resources, or data sources.
  • An entry has been added to the changelog, if necessary.

wilsonehusin
wilsonehusin approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@wilsonehusin wilsonehusin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@bobbytables bobbytables merged commit 85a478a into main Oct 24, 2024
1 check passed
@bobbytables bobbytables deleted the handle-deleted-escalation-policies-correctly branch October 24, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilsonehusin wilsonehusin wilsonehusin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobbytables @wilsonehusin